poke-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] pkl: Fix leaking of exceptions inside try blocks


From: Jose E. Marchesi
Subject: Re: [PATCH 1/2] pkl: Fix leaking of exceptions inside try blocks
Date: Sun, 26 Dec 2021 19:50:46 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

> Hi Mohammad.
>
>> Without this patch the code generator leaves the exception(s) in
>> exception stack for the following code:
>>
>>   try return something;
>>   catch {}
>>
>> 2021-12-26  Mohammad-Reza Nabipoor  <mnabipoor@gnu.org>
>>
>>      * libpoke/pkl-ast.h (struct pkl_ast_return_stmt): Add new field
>>      `npopes` (number of `pope`s).
>>      (PKL_AST_RETURN_STMT_NPOPES): New macro.
>>      * libpoke/pkl-ast.c (pkl_ast_finish_returns_1): Add new arg `npopes`
>>      to count the `pope`s.
>>      (pkl_ast_finish_returns): Likewise.
>>      * libpoke/pkl-gen.c (pkl_gen_ps_return_stmt): Insert necessary `pope`
>>      instruction(s).
>
> Very nice catch (:P) and OK for master.

Actually, it is probably good to install this in maint/poke-1 as well,
in case we release a bugfix release.

Thanks.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]