Re: [PATCH 07/12] libpoke: Add `__pkl_unsafe_string_set` builtin

[Mohammad-Reza Nabipoor]

On Thu, May 27, 2021 at 02:00:04PM +0200, Jose E. Marchesi wrote:
> 
> > diff --git a/testsuite/poke.pkl/unsafe-string-set-diag-1.pk 
> > b/testsuite/poke.pkl/unsafe-string-set-diag-1.pk
> > new file mode 100644
> > index 00000000..d3f35ed5
> > --- /dev/null
> > +++ b/testsuite/poke.pkl/unsafe-string-set-diag-1.pk
> > @@ -0,0 +1,5 @@
> > +/* { dg-do run } */
> > +
> > +var s = "Earth";
> > +
> > +__pkl_unsafe_string_set(s, 2, "Mars");  /* { dg-output "unhandled out of 
> > bounds exception" } */
> 
> Please leave a space after (.
> 
> > diff --git a/testsuite/poke.pkl/unsafe-string-set-diag-2.pk 
> > b/testsuite/poke.pkl/unsafe-string-set-diag-2.pk
> > new file mode 100644
> > index 00000000..65dcf2fe
> > --- /dev/null
> > +++ b/testsuite/poke.pkl/unsafe-string-set-diag-2.pk
> > @@ -0,0 +1,5 @@
> > +/* { dg-do run } */
> > +
> > +var s = "Mars";
> > +
> > +__pkl_unsafe_string_set(s, 0, "Earth");  /* { dg-output "unhandled out of 
> > bounds exception" } */
> 
> Ditto.
> Other than that this is OK for master.
> Thanks!
> 

Pushed to both master and maint/poke-1 (as you said in the reply to the next
message to enable the next fix (%v in printf)).
Thanks.