[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 07/12] libpoke: Add `__pkl_unsafe_string_set` builtin
|
From: |
Jose E. Marchesi |
|
Subject: |
Re: [PATCH 07/12] libpoke: Add `__pkl_unsafe_string_set` builtin |
|
Date: |
Thu, 27 May 2021 14:00:04 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
> diff --git a/testsuite/poke.pkl/unsafe-string-set-diag-1.pk
> b/testsuite/poke.pkl/unsafe-string-set-diag-1.pk
> new file mode 100644
> index 00000000..d3f35ed5
> --- /dev/null
> +++ b/testsuite/poke.pkl/unsafe-string-set-diag-1.pk
> @@ -0,0 +1,5 @@
> +/* { dg-do run } */
> +
> +var s = "Earth";
> +
> +__pkl_unsafe_string_set(s, 2, "Mars"); /* { dg-output "unhandled out of
> bounds exception" } */
Please leave a space after (.
> diff --git a/testsuite/poke.pkl/unsafe-string-set-diag-2.pk
> b/testsuite/poke.pkl/unsafe-string-set-diag-2.pk
> new file mode 100644
> index 00000000..65dcf2fe
> --- /dev/null
> +++ b/testsuite/poke.pkl/unsafe-string-set-diag-2.pk
> @@ -0,0 +1,5 @@
> +/* { dg-do run } */
> +
> +var s = "Mars";
> +
> +__pkl_unsafe_string_set(s, 0, "Earth"); /* { dg-output "unhandled out of
> bounds exception" } */
Ditto.
Other than that this is OK for master.
Thanks!
- [PATCH 04/12] libpoke/pvm.jitter: Use more `pvm_make_string_nodup`, (continued)
- [PATCH 04/12] libpoke/pvm.jitter: Use more `pvm_make_string_nodup`, Mohammad-Reza Nabipoor, 2021/05/25
- [PATCH 05/12] libpoke/pkl-rt.pk: Fix typo s/gigi/gibi/, Mohammad-Reza Nabipoor, 2021/05/25
- [PATCH 06/12] libpoke: Fix trivial errors, Mohammad-Reza Nabipoor, 2021/05/25
- [PATCH 07/12] libpoke: Add `__pkl_unsafe_string_set` builtin, Mohammad-Reza Nabipoor, 2021/05/25
- Re: [PATCH 07/12] libpoke: Add `__pkl_unsafe_string_set` builtin,
Jose E. Marchesi <=
- [PATCH 08/12] libpoke: Fix printf %v for strings to give valid literals, Mohammad-Reza Nabipoor, 2021/05/25
- [PATCH 09/12] libpoke: Fix a bug and add assertions to pvm_make_*, Mohammad-Reza Nabipoor, 2021/05/25
- [PATCH 10/12] libpoke: Add skeleton for string properties instructions, Mohammad-Reza Nabipoor, 2021/05/25
- [PATCH 11/12] libpoke: Add `format`, Mohammad-Reza Nabipoor, 2021/05/25