poke-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3] libpoke: free the buffer of stream device only in read mo


From: Mohammad-Reza Nabipoor
Subject: Re: [PATCH v3] libpoke: free the buffer of stream device only in read mode
Date: Tue, 20 Oct 2020 02:39:10 +0330

On Mon, Oct 19, 2020 at 12:04:05AM +0200, Jose E. Marchesi wrote:
> 
> Hi.
> 
> > -int ios_buffer_free (struct ios_buffer *buffer);
> > +void
> > +ios_buffer_free (struct ios_buffer *buffer);
> 
> Function prototypes should't feature the name of the function at the
> first column, i.e. please use this instead:
> 
> void ios_buffer_free (struct ios_buffer *buffer);
> 
> Other than that, this is OK  for master.
> Thanks!
> 

Pushed.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]