|
From: | Jose E. Marchesi |
Subject: | Re: [PATCH v3] libpoke: free the buffer of stream device only in read mode |
Date: | Mon, 19 Oct 2020 00:04:05 +0200 |
User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Hi. > -int ios_buffer_free (struct ios_buffer *buffer); > +void > +ios_buffer_free (struct ios_buffer *buffer); Function prototypes should't feature the name of the function at the first column, i.e. please use this instead: void ios_buffer_free (struct ios_buffer *buffer); Other than that, this is OK for master. Thanks! PS: please don't forget to run make syntax-check before pushing your changes.
[Prev in Thread] | Current Thread | [Next in Thread] |