[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] crc.pk: New file
From: |
Jose E. Marchesi |
Subject: |
Re: [PATCH] crc.pk: New file |
Date: |
Wed, 27 Nov 2019 16:12:14 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Is this crc32_update function useful by itself? If not, I would have
it
defined inside crc32_cal, called `update'.
I can envisage a scenarios where it might be useful by itself, although
admittedly such situations would be rare.
So, at this point, I would define both crc32_update and crc32_table
inside crc32_cal, I would rename the function to crc32 and put it in
src/std.pk.