poke-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] crc.pk: New file


From: John Darrington
Subject: Re: [PATCH] crc.pk: New file
Date: Wed, 27 Nov 2019 16:08:24 +0100
User-agent: NeoMutt/20170113 (1.7.2)

On Wed, Nov 27, 2019 at 03:39:56PM +0100, Jose E. Marchesi wrote:
     
     
     If this is a pickle, it should go to pickle/ instead of src/.

Why make the distinction?  After all, the all end up getting installed
in the same place.

     Is this crc32_update function useful by itself?  If not, I would have it
     defined inside crc32_cal, called `update'.

I can envisage a scenarios where it might be useful by itself, although
admittedly such situations would be rare.
     
J'



reply via email to

[Prev in Thread] Current Thread [Next in Thread]