Re: [pdf-devel] PDF_FORCE_BIGNUM

[jemarch]

Hi Jeff.

   In config.h near line 790, there's the following comment:

   /* Force the usage of the 64bits bignum implementation even if the system
      support a suitable native type */
   /* #undef PDF_FORCE_BIGNUMS */

   I think the comment could be revised to better reflect preprocessor state:
   /* Force the usage of the 64bits bignum implementation even if the system
      support a suitable native type */
   /* #define PDF_FORCE_BIGNUMS */

The config.h file is generated by the configure script, that in turn
uses a template called config.h.in that is generated by autoheader
(when you invoke the bootstrap script).

The above entry in config.h.in is generated from this fragment of
configure.ac:

   AC_DEFINE([PDF_FORCE_BIGNUMS],[1],[Force the usage of the 64bits bignum 
implementation even if the system support a suitable native type])

   In addition, types.h has the following comment around line 140:

   /* Note that int64_t may be defined by the gnulib stdint.h in
      platforms missing that header file. */
   #if (defined(HAVE_INT64_T) || defined(int64_t)) && 
!defined(PDF_FORCE_BIGNUMS)
   #define PDF_USE_BUILTIN_64BIT_SUPPORT
   #endif

   Its not enough to '#define PDF_FORCE_BIGNUMS' in types.h (apparently,
   some modules do not treat pdf_i64_t opaquely, or do not honor
   PDF_USE_BUILTIN_64BIT_SUPPORT).

Which modules are those?  We definitely want to fix that.

   A more appropriate comment might be:

   /* Note that int64_t may be defined by the gnulib stdint.h in
      platforms missing that header file. To force use of BIGNUM,
      define PDF_FORCE_BIGNUMS in config.h */
   #if (defined(HAVE_INT64_T) || defined(int64_t)) && 
!defined(PDF_FORCE_BIGNUMS)
   #define PDF_USE_BUILTIN_64BIT_SUPPORT
   #endif

I pushed that clarification to trunk.

Thanks.

--
Jose E. Marchesi  <address@hidden>
                  http://www.jemarch.net
GNU Project       http://www.gnu.org