Re: Switch to std::atomic?

[John W. Eaton]

On 9/27/19 3:48 AM, Pantxo wrote:
> John W. Eaton wrote
> > On 9/25/19 6:10 PM, John W. Eaton wrote:
> >
> > I ended up pushing the following three changes:
> >
> >     http://hg.savannah.gnu.org/hgweb/octave/rev/c98953e85220
> >     http://hg.savannah.gnu.org/hgweb/octave/rev/c23aee2104de
> >     http://hg.savannah.gnu.org/hgweb/octave/rev/396996f1dad0
>
> I am unable to compile Octave with gcc 6.3 (the default in debian stretch)
> and OpenMP. I get a bunch of error that look as follows:
>
> In file included from ../octave/liboctave/util/oct-atomic.c:29:0:
> /usr/lib/gcc/x86_64-linux-gnu/6/include/stdatomic.h:40:1: sorry,
> unimplemented: ‘_Atomic’ with OpenMP
>   typedef _Atomic _Bool atomic_bool;
>
> This seems to have been fixed in later varsions of gcc, see
>
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65467

Does the attached patch avoid the problem for you with GCC 6.3?  I'm 
assuming HAVE_STDATOMIC_H will be defined only if it can be included 
without error, and that will be a sufficient test to avoid it if the 
compiler has the problem you show above.

jwe

diffs.txt
Description: Text document