Re: pending dataframe-1.2.0 release

[Olaf Till]

On Sat, Aug 19, 2017 at 10:01:35AM -0700, CdeMills wrote:
> CdeMills wrote
> > On Tue, 15 Aug 2017 13:00:06 +0200, Olaf Till wrote:
> >> Pascal,
> >>
> >> there is still much to do:
> >>
> >> - Please pull from the repository, I've updated the root level
> >>   Makefile.
> >>
> 
> Olaf,
> the issues mentioned so far should have been solved in the last push I made
> on SF:
> 1) adapted the license texts as requested. Many files where touched by that.
> 2) there was a longstanding bug in strsplit() call. In case more than one
> separator are used (typically "\t" and ","), put them in a cellstr instead
> of concatenating them in a single string
> 3) one test failed as a matrix was accessed past its end. Corrected.
> 
> Could you please have a look ?

Extensive changes, thanks...

I've pushed a change to the root level Makefile, to call
dataframe_test in 'make check'.

dataframe_test.m seems non-trivial to me, so could you add a copyright
and license to it?

Calling dataframe_test, lines 191--193 (left division) didn't pass for
me without specifying a tolerance...


The rest is ok for the release (though we didn't as yet discuss the
'Matlab oriented coding style' issue further).

You probably don't need to upload a further tarball, it should be
enough if I generate it at my machine after you've done the last
polish to dataframe_test.m

Olaf

-- 
public key id EAFE0591, e.g. on x-hkp://pool.sks-keyservers.net

signature.asc
Description: Digital signature