Re: Thread-safety issues in QtHandles

[Michael Goffioul]

On Mon, Nov 7, 2011 at 8:25 AM, John W. Eaton <address@hidden> wrote:
> On  5-Nov-2011, Michael Goffioul wrote:
>
> | I'm fine with your change. I suggest you apply it, so I can build my
> | patch on it. AFAIK, if valgrind reports uninitialized values, they
> | were also uninitialized before removing the octave_allocator, as that
> | class doesn't initialize the allocated memory. And if the memory was
> | initialized from a previous allocation, then the content is wrong
> | anyway. In that regards, I don't think removing octave_allocator
> | changed anything.
>
> Right, I didn't mean to imply that things were correct previously.  I
> was just thinking that the implementation of the octave_allocator
> class could explain why valgrind doesn't see errors about
> uninitialized data.

I didn't mean you meant that either :) I was just thinking out loud.

BTW, the patch I sent contained 2 errors that prevent compilation. The
attached patch fix that: compilation OK, test suite OK. There's no
functional difference from the previous one, but at least you can test
this one.

Michael.

thread_safe_refcount.bz2
Description: BZip2 compressed data