Re: linestyleorder and scatter plots markerfacecolor and markeredgecolor properties

[David Bateman]

Ben Abbott wrote:
> On Jan 19, 2010, at 8:55 PM, David Bateman wrote:
>
>   
> > Michael Goffioul wrote:
> >     
> > > On Sun, Jan 17, 2010 at 10:14 PM, David Bateman <address@hidden> wrote:
> > >  
> > >       
> > > > For information here is a patch that I'm working on that does the following
> > > >
> > > > * It removes the "@" markers I recently added
> > > > * It implements setting the linestyleorder with either a string or a string
> > > > cell array
> > > > * Adds an graphics property order_property to handle the above
> > > >    
> > > >         
> > > [ sorry, I hit "Send" too fast]
> > >
> > > I'd rather see a more generic stringvector_property class that would
> > > usable for other properties, e.g. tick labels. This can be changed later
> > > on, but my idea is to make the property configurable:
> > > - being able to specify the spliiter character
> > > - being able to specify the default returned format:
> > >       . default: returns the property value in the same format as it was set
> > >       . string: returns always in string format
> > >       . cellstr: returns always in cell array of strings format
> > >
> > > Michael.
> > >
> > >  
> > >       
> > The attached version implements it the way you want. I believe the 
> > linestyleorder property should always return a string however and so I forced 
> > it to do so even if a cell array is given to it. I pushed this to savannah
> >
> > D.
> >     
>
> David, I'm seeing an error while running "rundemos plot"
>
>         /Users/bpabbott/Development/mercurial/local_clone/scripts/plot/clabel.m 
> example 2: failed
> 	set: invalid value for radio property "linestyle"Press <enter> to continue: 
>
> I'm seeing other problems as well, but they appear to be related to the 
> background color.
>
> Ben
>
>
>
>
>   
I had to make the default linestyle "" rather than "-" to flag that the 
linestyle should come from the axes property linestyleorder in a similar 
manner to the color property of the line was already treated. I tried to 
fix this in all of the places that __pltopt__ was used but I missed this 
one.. Trivial changeset attached

D.




--
David Bateman                                address@hidden
35 rue Gambetta                              +33 1 46 04 02 18 (Home)
92100 Boulogne-Billancourt FRANCE            +33 6 72 01 06 33 (Mob)

# HG changeset patch
# User David Bateman <address@hidden>
# Date 1264029401 -3600
# Node ID f481496013a265952008f21162c150ce1bb51949
# Parent  d0ce5e973937be7f52e4100909f2794031630fc3
Set default line style in __contour__

diff --git a/scripts/ChangeLog b/scripts/ChangeLog
--- a/scripts/ChangeLog
+++ b/scripts/ChangeLog
@@ -1,3 +1,8 @@
+2010-01-20  David Bateman  <address@hidden>
+
+       * plot/private/__contour__.m: Set default linestyle if pltopt returns
+       an empty style.
+
 2010-01-20  John W. Eaton  <address@hidden>
 
        * time/datetick.m: Make form arg optional.
@@ -8,7 +13,6 @@
        * plot/__go_draw_axes__.m: Correct an error in drawing of patch
        objects where unrequested markers were drawn.
 
-
        * plot/__go_draw_figure__.m: Also plot white foreground and
        background colors.
        * plot/plotyy.m: Set axes colors to "none".
diff --git a/scripts/plot/private/__contour__.m 
b/scripts/plot/private/__contour__.m
--- a/scripts/plot/private/__contour__.m
+++ b/scripts/plot/private/__contour__.m
@@ -36,6 +36,9 @@
       if (isempty (linespec.color))
        linespec.color = "auto";
       endif
+      if (isempty (linespec.linestyle))
+       linespec.linestyle = "-";
+      endif
       if (valid)
        have_line_spec = true;
        varargin(i) = [];