octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: UGLY_DEFS for darwin in configure.in


From: John W. Eaton
Subject: Re: UGLY_DEFS for darwin in configure.in
Date: Wed, 03 Oct 2007 12:54:36 -0400

On  3-Oct-2007, Thomas Treichl wrote:

| Mac people should here again be part of the big Unix community as long as 
they 
| are not able to build Octave with Mac's sed anymore and therefore they must 
| install a newer version of sed and then the following special darwin lines 
don't 
| work anymore:
| 
|    *-*-darwin*)
|      UGLY_DEFS=`echo $DEFS | sed 
's,\\",\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\",g'`
|    ;;
|    *)
|      UGLY_DEFS=`echo $DEFS | sed 's,\\",\\\\\\\\\\\\\\\\\\",g'`
|    ;;

OK, so this is just another example of how testing for OS or version
instead of the actual bug/broken feature is a bad idea.  So instead of
this code, how about a feature test for sed that tests for the quoting
problem?  If we remove this check, then I'm sure there will be some
people still using the broken sed who will then complain to the list
that they can't build Octave.  Or are you saying that doesn't matter
now, that these systems are now the rare exception?

jwe


reply via email to

[Prev in Thread] Current Thread [Next in Thread]