[Octave-bug-tracker] [bug #60311] Static variable in eigs may cause SIGSEGV after exit

[Markus Mützel]

Update of bug #60311 (project octave):

                  Status:                    None => Need Info              
        Operating System:               GNU/Linux => Any                    

    _______________________________________________________

Follow-up Comment #1:

Thanks for your patch. I haven't tested it yet. But it looks good to me in
principle.

Afaict, reducing the number of static variables is something jwe is also
interested in.

Since this fixes a potential segmentation fault, I'd like to push on stable.
I'm not sure this is possible with the current patch though.
Does changing a typedef in a distributed header from a function pointer to a
std::function constitute an API change? (I'm afraid it might.)

If it does, we should probably first fix the SIGSEGV on stable by resetting
the static variable `eigs_fcn` like you suggested. And then get rid of the
static variables on default in a second patch.

Also the construct with the functional shadowing a local function seems a bit
odd to me.
Would it be possible to use a different name for the functional to make it
clearer what is used where?

Could you please provide patches for these steps?

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?60311>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/