[Octave-bug-tracker] [bug #55727] Feature request: add GEJSV as an additional svd_drivers

[Markus Mützel]

Follow-up Comment #9, bug #55727 (project octave):

@Philip: That sounds like a good approach to me.
For a start, it might be good enough for an initial hint to get the backtrace
from the build you currently have.

Checking the changes again, it looks like the default driver might have
changed:

--- a/libinterp/corefcn/svd.cc
+++ b/libinterp/corefcn/svd.cc
@@ -62,9 +62,12 @@
 static typename octave::math::svd<T>::Driver
 svd_driver (void)
 {
-  return (Vsvd_driver == "gesvd"
-          ? octave::math::svd<T>::Driver::GESVD
-          : octave::math::svd<T>::Driver::GESDD);
+  if (Vsvd_driver == "gejsv")
+      return octave::math::svd<T>::Driver::GEJSV;
+  else if (Vsvd_driver == "gesdd")
+      return octave::math::svd<T>::Driver::GESDD;
+  else
+      return octave::math::svd<T>::Driver::GESVD;  // default
 }
 


The new default matches the documentation though.

Also, the w64-64-default builder seems to complain about incompatible integer
assignments:
http://buildbot.octave.org:8010/#/builders/18/builds/824/steps/8/logs/stdio

Compilation also stopped. But there's no reference to the error in the log
file excerpt.
I'll try to setup a build setup with similar configuration and see if I can
reproduce the error.

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?55727>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/