octave-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #59022] [octave forge] (image) test failures i


From: Hartmut
Subject: [Octave-bug-tracker] [bug #59022] [octave forge] (image) test failures in blockproc.m under Octave 6.0.90
Date: Fri, 28 Aug 2020 17:26:24 -0400 (EDT)
User-agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:80.0) Gecko/20100101 Firefox/80.0

Follow-up Comment #10, bug #59022 (project octave):

Please review the attached PATCH to fix this. It
* also allows class "inline" for the fun parameter
* changes all test from using "inline" functions to anonymous functions
* adds one single test to check of inline functions still work
* adds plenty of whitespace to improve coding style

I think I would like to continue the (existing) support of blockproc for
"inline" functions, as long as they are supported by core Octave. (Why destroy
something that already works?)

I think this patch should go to the stable  branch, since it mostly only
changes unit tests. 

And I think this does not need to trigger a soon "emergency release" of the
image package. One (set of) failing unit test(s) under Octave 6.0 will hardly
be noticed by anybody. Inline functions won't work any more as inputs to
blockproc under the newest Octave versions for a while. But their usage will
trigger a warning when used under Octave 6.0. anyways.

Let me know your thoughts to this. Also feel free to adapt, change or push
this patch, because I will be offline for a couple weeks soon.

(file #49721)
    _______________________________________________________

Additional Item Attachment:

File name: blockproc_inline_V1.patch      Size:7 KB
   
<https://file.savannah.gnu.org/file/blockproc_inline_V1.patch?file_id=49721>



    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?59022>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]