[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-bug-tracker] [bug #57500] [octave forge] (image) imrotate fails
From: |
Carnë Draug |
Subject: |
[Octave-bug-tracker] [bug #57500] [octave forge] (image) imrotate fails in default branch |
Date: |
Sat, 25 Jan 2020 07:30:58 -0500 (EST) |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Firefox/68.0 |
Follow-up Comment #5, bug #57500 (project octave):
If we want to keep the "valid" feature, we should at least:
* check if "valid" is argout and default extrapvalue and error if not
appropriate for the image type
* we could fix the isna for something appropriate to the user choice of extrap
value.
However, this feature has been broken for a long time and no one reported it
which leads me to believe it may not be used at all. If it's not used, that's
a good argument to remove it and have less code to maintain, which means more
maintenance time to improve other features that may be more useful.
Obviously I am biased for the functions of the package that I do use, so if
you believe this is useful, go for it. If not, I would remove the extrapvalue
arguemnts and valid output arguments.
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/bugs/?57500>
_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/