[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Why force "-m64" on Solaris/X86?
From: |
Jan-Henrik Haukeland |
Subject: |
Re: Why force "-m64" on Solaris/X86? |
Date: |
Fri, 30 May 2014 12:30:10 +0200 |
This switch has been in the build code for a long time and I think it was
required as we were using 64-bits API interface. It is unclear if it can be
removed and build Monit for x86 without code changes. We only use and test
Solaris on 64-bits. If you want to change this and *can test and verify that
Monit works on Solaris 32-bits*, sure, we'll be happy to accept a Pull Request.
On 29 May 2014, at 00:01, Sergey Maslyakov <address@hidden> wrote:
> Any opinions on this? Somebody must have put the "-m64" switch there on
> purpose.
>
> If vendors do not object, I could open an issue to remove this switch for
> Solaris builds and to let the compiler or the user decide whether to force
> 64-bit mode or not. I think the flag makes it more restrictive than it should
> and results in build failures with 32-bit compilers on Solaris/X86.
>
> Please let me know if this worth doing and I will self-assign the ticket and
> contribute the fix. But if it will be rejected, I'd like to know this before
> I start.
>
>
> Thank you,
> /Sergey