[Mldonkey-users] [patch #5775] [FIX] load URLs with ()'

[orbit]

Follow-up Comment #7, patch #5775 (project mldonkey):

no, patch doesn't break it

and I only assume it doesn't work (couldn't find such an URL)
ATM space is encoded %20 most servers should decode that to space

I think this line can't hurt either

diff -u -r1.36 http_client.ml
--- src/utils/net/http_client.ml        4 Feb 2007 17:27:45 -0000       1.36
+++ src/utils/net/http_client.ml        6 Mar 2007 23:51:25 -0000
@@ -90,8 +90,7 @@
       then  Url.to_string_no_args url
       else url.short_file
     in
-  (* I get a lot more bittorrent urls with this line: *)
-  let url = (Str.global_replace (Str.regexp " ") "%20" url) in
+  let url = Url.encode url in
     let url = if is_real_post then url else
         Url.put_args url args
     in


anyway this encode decode URL code is a mess because it's used on many
places, without conception

e.g.: submits get decoded twice, some requests don't get encoded (see patch
above)

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?5775>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/