mldonkey-users
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Mldonkey-users] [patch #5775] [FIX] load URLs with ()'


From: orbit
Subject: [Mldonkey-users] [patch #5775] [FIX] load URLs with ()'
Date: Sun, 04 Mar 2007 21:42:56 +0000
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.1) Gecko/20061205 Iceweasel/2.0.0.1 (Debian-2.0.0.1+dfsg-2)

Follow-up Comment #3, patch #5775 (project mldonkey):

final patch, so far ;)
* loads URLs with chars '()+

de-/encoding should look like this

http://www.foo.foo/foo+foo.php?foo=foo foo
encode to:
http://www.foo.foo/foo%2Bfoo.php?foo=foo+foo
and vice versa decode to first line

----

so only url.args should be decoded according to x-www-form-urlencoded
(replaces '+' with ' ')

the rest of the URL should be decoded RCF 1738 style

I changed the default decoding method to raw RFC 1738

at some places in code we decode the whole URL with decode
perhaps we shouldn't do that, see "network_parse_url"

----

the same goes for encode
at the moment we encode all RFC
(someone changed it and didn't correct the comment)
in web interface this doesn't matter (browser encodes for us)
but URLs submitted by telnet or gui are affected
so dllink "http://foo.foo/foo?foo=foo foo" won't work with them, but I can
live with that ;-)


note: x-www-form-urlencoded is used by browsers when submitting input fields,
try to wireshark a google search

(file #12107)
    _______________________________________________________

Additional Item Attachment:

File name: url_final.patch                Size:6 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?5775>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/





reply via email to

[Prev in Thread] Current Thread [Next in Thread]