Re: [lwip-devel] [Patch] missing indent in stats.c

[address@hidden]

Kieran Mansley wrote:
> On 24 Feb 2012, at 20:46, Gisle Vanem wrote:
>
> > Shouldn't there be some extra indenting in stats.c? Like this:
> >
> > --- Git-latest\src\core\stats.c    Mon Oct 24 13:34:20 2011
> > +++ src\core\stats.c Tue Nov 29 22:59:26 2011
> > @@ -99,8 +99,8 @@
> >   LWIP_PLATFORM_DIAG(("memerr: %"STAT_COUNTER_F"\n\t", igmp->memerr));
> >   LWIP_PLATFORM_DIAG(("proterr: %"STAT_COUNTER_F"\n\t", igmp->proterr));
> >   LWIP_PLATFORM_DIAG(("rx_v1: %"STAT_COUNTER_F"\n\t", igmp->rx_v1));
> > -  LWIP_PLATFORM_DIAG(("rx_group: %"STAT_COUNTER_F"\n", igmp->rx_group));
> > -  LWIP_PLATFORM_DIAG(("rx_general: %"STAT_COUNTER_F"\n", igmp->rx_general));
> > +  LWIP_PLATFORM_DIAG(("rx_group: %"STAT_COUNTER_F"\n\t", igmp->rx_group));
> > +  LWIP_PLATFORM_DIAG(("rx_general: %"STAT_COUNTER_F"\n\t", igmp->rx_general));
> >   LWIP_PLATFORM_DIAG(("rx_report: %"STAT_COUNTER_F"\n\t", igmp->rx_report));
> >   LWIP_PLATFORM_DIAG(("tx_join: %"STAT_COUNTER_F"\n\t", igmp->tx_join));
> >   LWIP_PLATFORM_DIAG(("tx_leave: %"STAT_COUNTER_F"\n\t", igmp->tx_leave));
> It makes sense to me that they should all be consistent, and we need to add the 
> missing \t that your patch adds.  Could you file a bug on savannah so that it 
> doesn't get forgotten?

No need to, I've already fixed that. Seems like I have forgotten to 
reply to that mail to update the status, sorry.

http://git.savannah.gnu.org/cgit/lwip.git/commit/?id=193ccaa3b4ac52243ad6f83ba6a5e492c2c4c777

Simon