Re: [lwip-devel] IPH_V() and IPH_HL(hdr) macro endianess

[Ivan Delamer]

Weird!

I don't remember seing that code when I used it to develop IP6H_V, etc...


> Date: Sun, 28 Aug 2011 16:29:34 +0200
> From: Leon Woestenberg <address@hidden>
> To: lwip-devel <address@hidden>
> Subject: [lwip-devel] IPH_V() and IPH_HL(hdr) macro endianess
>       dependence?
> Message-ID:
>       <address@hidden>
> Content-Type: text/plain; charset=ISO-8859-1
>
> Hello,
>
> since when is nibble order dependent on byte endianess?
>
> 41c785d7        (Simon Goldschmidt      2011-07-26 20:55:32 +0200
>  94)#if BYTE_ORDER == LITTLE_ENDIAN
> 41c785d7        (Simon Goldschmidt      2011-07-26 20:55:32 +0200
>  95)#define IPH_V(hdr)  ((hdr)->_v_hl >> 4)
> 41c785d7        (Simon Goldschmidt      2011-07-26 20:55:32 +0200
>  96)#define IPH_HL(hdr) ((hdr)->_v_hl & 0x0f)
> 41c785d7        (Simon Goldschmidt      2011-07-26 20:55:32 +0200
>  97)#else /* BYTE_ORDER == LITTLE_ENDIAN */
> 41c785d7        (Simon Goldschmidt      2011-07-26 20:55:32 +0200
>  98)#define IPH_V(hdr)  ((hdr)->_v_hl & 0x0f)
> 41c785d7        (Simon Goldschmidt      2011-07-26 20:55:32 +0200
>  99)#define IPH_HL(hdr) ((hdr)->_v_hl >> 4)
> 41c785d7        (Simon Goldschmidt      2011-07-26 20:55:32 +0200
>  100)#endif /* BYTE_ORDER == LITTLE_ENDIAN */
>
>
> Sorry, but I do not get how this code gets into HEAD? This cost me
> hours of debugging finding this code and is rather frustrating.
>
> Proposal: I would like to open the 1.4.0 release branch for bug fixes
> only, This is a not a playground. If a regression comes in today,
> tomorrow tens of people will suffer from it.
>
> Regards,
> --
> Leon
>
>
>
> ------------------------------
>
> _______________________________________________
> lwip-devel mailing list
> address@hidden
> https://lists.nongnu.org/mailman/listinfo/lwip-devel
>
>
> End of lwip-devel Digest, Vol 86, Issue 15
> ******************************************
>