[lwip-devel] IPH_V() and IPH_HL(hdr) macro endianess dependence?

[Leon Woestenberg]

Hello,

since when is nibble order dependent on byte endianess?

41c785d7        (Simon Goldschmidt      2011-07-26 20:55:32 +0200
 94)#if BYTE_ORDER == LITTLE_ENDIAN
41c785d7        (Simon Goldschmidt      2011-07-26 20:55:32 +0200
 95)#define IPH_V(hdr)  ((hdr)->_v_hl >> 4)
41c785d7        (Simon Goldschmidt      2011-07-26 20:55:32 +0200
 96)#define IPH_HL(hdr) ((hdr)->_v_hl & 0x0f)
41c785d7        (Simon Goldschmidt      2011-07-26 20:55:32 +0200
 97)#else /* BYTE_ORDER == LITTLE_ENDIAN */
41c785d7        (Simon Goldschmidt      2011-07-26 20:55:32 +0200
 98)#define IPH_V(hdr)  ((hdr)->_v_hl & 0x0f)
41c785d7        (Simon Goldschmidt      2011-07-26 20:55:32 +0200
 99)#define IPH_HL(hdr) ((hdr)->_v_hl >> 4)
41c785d7        (Simon Goldschmidt      2011-07-26 20:55:32 +0200
 100)#endif /* BYTE_ORDER == LITTLE_ENDIAN */


Sorry, but I do not get how this code gets into HEAD? This cost me
hours of debugging finding this code and is rather frustrating.

Proposal: I would like to open the 1.4.0 release branch for bug fixes
only, This is a not a playground. If a regression comes in today,
tomorrow tens of people will suffer from it.

Regards,
-- 
Leon