|
From: | address@hidden |
Subject: | Re: [lwip-devel] byte order, packing, optimizations |
Date: | Mon, 15 Feb 2010 19:27:39 +0100 |
User-agent: | Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; de; rv:1.9.1.7) Gecko/20100111 Thunderbird/3.0.1 |
Stéphane Lesage wrote:
Personally, I'd like to see assertions or checks of some type if we remove structure packing from any structs that are exposed in headers (it's a different thing for structs internal to a C file).As we use ip_addr2 for compilers that don't support struct packing, it means packing is not necessary for ethernet / ARP headers.
The patch you attached does far more than that! And it's not clear to me if/why we need all that. Also, it interferes with / task #10173 <http://savannah.nongnu.org/task/?10173>/ (Add IPCOPY and HWACOPY): http://savannah.nongnu.org/task/?10173The proposed patch removes packing, and processes all addresses with u16_t accesses.
Simon
[Prev in Thread] | Current Thread | [Next in Thread] |