[lwip-devel] [task #6880] netconn API misses some error forwarding

[Frédéric Bernon]

Follow-up Comment #1, task #6880 (project lwip):

I can check it if you want. 

If I look in api_msg.c, most of functions report "local" error with a
"msg->conn->err = err;" before the "sys_mbox_post", like in :

do_write
do_close
do_join_leave_group

What do you prefer? Directly set conn->err, or only update it at the end?

In a general way, in "do_" functions, some "case" are done where they do
nothing, like in do_close (only "case NETCONN_TCP:" is really usefull).
Others, like do_write, set errors like "msg->conn->err = ERR_VAL;". I propose
to replace most of TCP specific "switch"  by a simple "if
(msg->conn->type==NETCONN_TCP)" (code would be simpler, and a switch can't be
optimized by compiler).




    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/task/?6880>

_______________________________________________
  Message posté via/par Savannah
  http://savannah.nongnu.org/