[lwip-devel] [bug #19177] Faulty arp initialization in ethernetif_init skeleton

[Jonathan Larmour]

Follow-up Comment #8, bug #19177 (project lwip):

I think we may as well have the default as enabled (1) as it is the common
case, was sort of already the default (as long as the user built the etharp
module) and I guess *one* of the underlying netif interfaces should be
enabled by default, so it can be that one. Just my opinion.

Re comment 5: I think LWIP_ARP is fine, although LWIP_ETHARP might be clearer
and more in line with the filename. Your choice :-).

If we have a LWIP_ARP define, then etharp_init() can be called from
tcpip_thread() before the call to tcpip_init_done(), but only #if LWIP_ARP.

Note, this would need a documentation/Changelog update (and changes to the
contributed ports) because the port will now no longer call etharp_init
itself. But this is an improvement - simplifying ports is good.


    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?19177>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/