[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lwip-devel] [bug #19177] Faulty arp initialization in ethernetif_init s
From: |
Jonathan Larmour |
Subject: |
[lwip-devel] [bug #19177] Faulty arp initialization in ethernetif_init skeleton |
Date: |
Fri, 23 Mar 2007 07:04:51 +0000 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.13) Gecko/20060513 Fedora/1.0.8-1.1.fc3.1.legacy Firefox/1.0.8 |
Update of bug #19177 (project lwip):
Status: Fixed => None
Open/Closed: Closed => Open
_______________________________________________________
Follow-up Comment #4:
This patch is incorrect. PPP and SLIP users without ethernet interfaces
should not have the ARP timer (and probably won't be building netif/etharp.c
in the first place). That's why in the mail thread on lwip-users I was saying
it would happen in the port's tcpip_init_done callback because the port knows
whether there are any ethernet interfaces, and tcpip.c does not.
Either it should be left to the port, or there should be something like a new
LWIP_ETH (or ETH_SUPPORT?) feature test macro in opt.h (overriden by the
port's lwipopts.h), which can be used to make the ARP timer init
conditional.
I think adding something like LWIP_ETH would make things simpler overall.
Separately, on the move of etharp_init to tcpip_init_done, I would think that
if this change stays, it's important that this new requirement for ports is
highlighted (and the example ports in contrib/ should be updated). But if we
did have the ability to test for LWIP_ETH, then we could add etharp_init to
tcpip_init.
_______________________________________________________
Reply to this item at:
<http://savannah.nongnu.org/bugs/?19177>
_______________________________________________
Message sent via/by Savannah
http://savannah.nongnu.org/
- [lwip-devel] [bug #19177] Faulty arp initialization in ethernetif_init skeleton, Thomas Taranowski, 2007/03/01
- [lwip-devel] [bug #19177] Faulty arp initialization in ethernetif_init skeleton, Frédéric BERNON, 2007/03/01
- RE: [lwip-devel] [bug #19177] Faulty arp initialization inethernetif_init skeleton, Taranowski, Thomas \(SWCOE\), 2007/03/01
- [lwip-devel] [bug #19177] Faulty arp initialization in ethernetif_init skeleton, Thomas Taranowski, 2007/03/03
- [lwip-devel] [bug #19177] Faulty arp initialization in ethernetif_init skeleton, Frédéric Bernon, 2007/03/03
- [lwip-devel] [bug #19177] Faulty arp initialization in ethernetif_init skeleton, Frédéric Bernon, 2007/03/05
- [lwip-devel] [bug #19177] Faulty arp initialization in ethernetif_init skeleton, Frédéric Bernon, 2007/03/06
- [lwip-devel] [bug #19177] Faulty arp initialization in ethernetif_init skeleton,
Jonathan Larmour <=
- [lwip-devel] [bug #19177] Faulty arp initialization in ethernetif_init skeleton, Frédéric Bernon, 2007/03/23
- [lwip-devel] [bug #19177] Faulty arp initialization in ethernetif_init skeleton, Frédéric Bernon, 2007/03/26
- [lwip-devel] [bug #19177] Faulty arp initialization in ethernetif_init skeleton, Kieran Mansley, 2007/03/26
- [lwip-devel] [bug #19177] Faulty arp initialization in ethernetif_init skeleton, Jonathan Larmour, 2007/03/26
- [lwip-devel] [bug #19177] Faulty arp initialization in ethernetif_init skeleton, Frédéric Bernon, 2007/03/26
- [lwip-devel] [bug #19177] Faulty arp initialization in ethernetif_init skeleton, Jonathan Larmour, 2007/03/26
- [lwip-devel] [bug #19177] Faulty arp initialization in ethernetif_init skeleton, Frédéric Bernon, 2007/03/26
- [lwip-devel] [bug #19177] Faulty arp initialization in ethernetif_init skeleton, Frédéric Bernon, 2007/03/26