[lwip-devel] [bug #19222] timeout in sys_mbox_fetch

[Frédéric Bernon]

Follow-up Comment #8, bug #19222 (project lwip):

Don't worry Dmitry, I will fix that tomorrow morning (I don't want this new
feature cause you any problems), but I hope other comments about that.

I will propose a configuration option to avoid increase footprint. Perhaps
LWIP_RCVTIMEO to enable/disable this feature ?

About sys_mbox_fetch implementation, perhaps that :

#define sys_mbox_fetch(m,d,t) sys_mbox_fetch_with_timeout(m,d,t,0)

footprint not increased, no sensible performance lost, source code
compatible, easy to change with LWIP_RCVTIMEO.

About sys_mbox_fetch_with_timeout implementation, some points to talk :

- I don't "like" sys_sem_wait_timeout, because it's only use per "select",
and sys_msleep (and in this last, implementation isn't efficent - already
done measures), and really increase footprint.

- I will test each one and will do cycles measures, to see if a there is a
real sensible difference.

- lwIP design seems to keep things as simple as possible, and I think an
implementation based on sys_arch_mbox_fetch's timeout is simple and
efficient. This is my personnal point of view...

So, is it possible to others developers to give their comments?

Good night and "see" you in some hours...


    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?19222>

_______________________________________________
  Message posté via/par Savannah
  http://savannah.nongnu.org/