Re: [lmi] [lmi-commits] master fc01b15e 4/4: Avoid overflow on integer multiplication

[Vadim Zeitlin]

On Fri, 13 May 2022 05:10:15 -0400 (EDT) Greg Chicares 
<gchicares@sbcglobal.net> wrote:

GC> branch: master
GC> commit fc01b15e6c4366ba449fa5898b9900f114d6ce22
GC> Author: Gregory W. Chicares <gchicares@sbcglobal.net>
GC> Commit: Gregory W. Chicares <gchicares@sbcglobal.net>
GC> 
GC>     Avoid overflow on integer multiplication

 I didn't have to fully digest the messages of the last few commits yet,
but I'm pretty sure that this means that an old task in my TODO list titled
"Run lmi under UBSAN" is actually of much higher priority than I thought.
UBSAN would detect all integer overflows (as well as quite a few other
things) and so I'd strongly recommend running full lmi system test with a
build using it.

 Should I try at least running the unit tests with UBSAN to see if there
are any low hanging bugs to fix already? Or will you do it with the full
test to kill of them with one stone? [*]

 Please let me know if I can do anything useful here,
VZ

[*] Sorry, I'm not using the mixed metaphors sanitizer with my emails yet.

pgp_ycvg3ev8j.pgp
Description: PGP signature