Re: [lmi] Is '-Wno-unused-variable' still needed?

[Vadim Zeitlin]

On Tue, 26 Oct 2021 20:42:36 +0000 Greg Chicares <gchicares@sbcglobal.net> 
wrote:

GC> On 10/26/21 3:40 PM, Vadim Zeitlin wrote:
GC> [...commit 3a66260de5a...]
GC> >  Unfortunately, this is still not quite the end of the story, as
GC> > re-enabling this warning for clang uncovered a few more occurrences of it,
GC> > all in the same test:
GC> [...]
GC> >  I think the first one might actually point to a typo in the test and
GC> > instead of
GC> > 
GC> >     constexpr currency zero {};
GC> >     LMI_TEST(   0 == a0.m_);
GC> > 
GC> > you might have meant to write
GC> > 
GC> >     constexpr currency zero {};
GC> >     LMI_TEST(   0 == zero.m_);
GC> 
GC> Correct. Thanks.
GC> 
GC> >  I've also pushed this commit as bcb72b820 to fix-clang-unused branch on
GC> > GitHub, so you can fetch it from there and cherry-pick or even
GC> > fast-forward, if you agree with the changes made in it.
GC> 
GC> Agreed. Pushing now.

 Excellent, thanks, CI is green again now, which means that I will be able
to continue with my other changes to it (using ccache, adding Bookworm
builds).

VZ

pgpA658naEtE8.pgp
Description: PGP signature