[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [lmi] Is '-Wno-unused-variable' still needed?
From: |
Greg Chicares |
Subject: |
Re: [lmi] Is '-Wno-unused-variable' still needed? |
Date: |
Tue, 26 Oct 2021 20:42:36 +0000 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 |
On 10/26/21 3:40 PM, Vadim Zeitlin wrote:
[...commit 3a66260de5a...]
> Unfortunately, this is still not quite the end of the story, as
> re-enabling this warning for clang uncovered a few more occurrences of it,
> all in the same test:
[...]
> I think the first one might actually point to a typo in the test and
> instead of
>
> constexpr currency zero {};
> LMI_TEST( 0 == a0.m_);
>
> you might have meant to write
>
> constexpr currency zero {};
> LMI_TEST( 0 == zero.m_);
Correct. Thanks.
> I've also pushed this commit as bcb72b820 to fix-clang-unused branch on
> GitHub, so you can fetch it from there and cherry-pick or even
> fast-forward, if you agree with the changes made in it.
Agreed. Pushing now.