Re: [lmi] [lmi-commits] master 92946c1: Create an XML catalog to forestall bogus errors

[Vadim Zeitlin]

On Tue,  3 Nov 2020 17:29:07 -0500 (EST) Greg Chicares 
<gchicares@sbcglobal.net> wrote:

GC> branch: master
GC> commit 92946c11ae79b5f1e654f4574a648a66372d2911
GC> Author: Gregory W. Chicares <gchicares@sbcglobal.net>
GC> Commit: Gregory W. Chicares <gchicares@sbcglobal.net>
GC> 
GC>     Create an XML catalog to forestall bogus errors
GC>     
GC>     See:
GC>       https://lists.nongnu.org/archive/html/lmi/2020-10/msg00103.html
GC>     et seqq.
GC>     
GC>     Lines and bytes of output:
GC>       2560 171891 previously
GC>       1671 100248 with this change
GC> ---
GC>  install_xml_libraries.sh | 30 +++++++++++++++++++++++++++++-
GC>  1 file changed, 29 insertions(+), 1 deletion(-)
GC> 
GC> diff --git a/install_xml_libraries.sh b/install_xml_libraries.sh
GC> index 4b29c42..88b059f 100755
GC> --- a/install_xml_libraries.sh
GC> +++ b/install_xml_libraries.sh
[...]
GC> @@ -179,6 +179,31 @@ if [ "$xml_skip_clean" != 1 ]; then
GC>      rm --force --recursive "$build_dir"
GC>  fi
GC>  
GC> +# Create an XML catalog 
#######################################################
GC> +
GC> +# This forestalls about a thousand lines of bogus error messages.
GC> +
GC> +throwaway_catalog=/etc/opt/lmi/xml_catalog

 Hello,

 Just a question: if it's throwaway, shouldn't it be created in /tmp (or
maybe ${TMP-/tmp})? As it is, the directory /etc/opt/lmi doesn't exist when
running install_msw.sh on native MSW and this results in the failure of the
installation process when running on a fresh system. So AFAICS we should
either add "mkdir --parents /etc/opt/lmi" line to install_msw.sh (I was
surprised to not find it there already, to be honest), or change the
directory used here.

 I could, of course, post the diff implementing either, or even both,
solutions, but it's so trivial that I don't know if it's worth it -- but
please let me know if it is.

 Thanks in advance,
VZ

pgpfrCidxr_H5.pgp
Description: PGP signature