lmi
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [lmi] PATCH: wxGrid-based census view


From: Greg Chicares
Subject: Re: [lmi] PATCH: wxGrid-based census view
Date: Mon, 17 Aug 2020 21:56:04 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0

On 2020-07-01 13:55, Vadim Zeitlin wrote:
[...]
>  So here, finally, are the changes implementing support for using wxGrid
> instead of wxDataViewCtrl in the census view: the first, main, PR which
> I'd like to ask you to merge is https://github.com/vadz/lmi/pull/143 and
> adds support for using wxGrid, while keeping using wxDataViewCtrl by
> default. To enable the new implementation, "--pyx=use_census_grid" command
> line option must be used.

It's a major improvement, and we're very happy with it and eager to
put it into production--probably at the end of September.

Thanks for taking the extra trouble to make the new and old
implementations switchable. Now that acceptance testing is complete,
would you mind tearing down and discarding that scaffolding, i.e.,
the "--pyx=use_census_grid" switch and the old wxDataViewCtrl
implementation, so that only the new wxGrid implementation remains?

That's not trivial; if it's going to take a while, I could just
revisit commit 3e9f8af66ad and mangle it to make wxGrid the default.
Or would that just make more work for you?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]