Re: [lmi] Regression in group-quote PDF

[Vadim Zeitlin]

On Thu, 13 Aug 2020 22:01:29 +0000 Greg Chicares <gchicares@sbcglobal.net> 
wrote:

GC> On 2020-08-13 20:15, Vadim Zeitlin wrote:
GC> > On Sat, 8 Aug 2020 18:57:47 +0000 Greg Chicares <gchicares@sbcglobal.net> 
wrote:
GC> [...]
GC> > GC> +    // PDF !! This should not be necessary--see:
GC> > GC> +    //   
https://lists.nongnu.org/archive/html/lmi/2020-08/msg00003.html
GC> > GC> +    wxDCTextBgModeChanger set_transparent_background(pdf_dc, 
wxPENSTYLE_TRANSPARENT);
GC> > 
GC> >  The argument is actually supposed to be wxBRUSHSTYLE_TRANSPARENT, but it
GC> > has exactly the same value as wxPENSTYLE_TRANSPARENT (and both have the
GC> > same value as just wxTRANSPARENT), so I don't think it's worth changing 
it,
GC> > especially as this line will be removed anyhow in the near future.
GC> 
GC> In 'include/wx/dc.h', I saw that wxDCTextBgModeChanger delegates
GC> to SetBackgroundMode(), whose definition is
GC>   virtual void SetBackgroundMode(int mode)
GC>     {m_pimpl_->SetBackgroundMode(mode);}
GC> and the permissible values of 'mode' aren't specified there.
GC> The test for wxBRUSHSTYLE_INVALID seems to imply that a
GC> "brush style" is wanted, but instead I followed the
GC> documentation, which seemed unmistakably clear (even if
GC> somewhat surprising):
GC> 
GC>   
https://docs.wxwidgets.org/trunk/classwx_d_c.html#a86c405ae265e6fdb4e393c4c9ada73c0
GC>   "mode may be one of wxPENSTYLE_SOLID and wxPENSTYLE_TRANSPARENT."
GC> 
GC> Is that documentation incorrect?

 Unfortunately it indeed was incorrect (and for a long time, too). I've
fixed this in

https://github.com/wxWidgets/wxWidgets/commit/e96155fecee150af5436fc26e8d55a4dbd8fc5f8

a few minutes ago, but it will take some time for the docs.wxwidgets.org
link above to get updated, as it's cached by CDN.

 Sorry about this mistake, I think it was introduced when replacing the
"generic" wxSOLID and wxTRANSPARENT constants with more specific ones and
nobody noticed it until now.

VZ

pgpNtz7HsF7FR.pgp
Description: PGP signature