Re: [lmi] Regression in group-quote PDF

[Greg Chicares]

On 2020-08-07 23:54, Vadim Zeitlin wrote:
> On Fri, 7 Aug 2020 17:19:25 +0000 Greg Chicares <gchicares@sbcglobal.net> 
> wrote:
> 
> GC> To reproduce:
> 
>  Thanks, I'll try to do it a.s.a.p., but probably not before the end of the
> next week.

All right. For the pending release (which notably includes wxWidgets
and wxPdfDoc upgrades), I'll commit a one-line fix in lmi.

>  There is wxDCTextBgModeChanger, however, which could be used if setting
> the background mode to transparent also helps.

Please tell me if this change (commit bf74aeba74) doesn't look right.
I've tested it, and it does seem to fix the problem. But it's hard
to find online examples that use these helper classes, and to figure
out the argument I had to poke around in the source.

---8<---8<---8<---8<---8<---8<---8<---8<---8<---8<---
diff --git a/group_quote_pdf_gen_wx.cpp b/group_quote_pdf_gen_wx.cpp
index 1cde4709..45ddc522 100644
--- a/group_quote_pdf_gen_wx.cpp
+++ b/group_quote_pdf_gen_wx.cpp
@@ -888,6 +888,9 @@ void group_quote_pdf_generator_wx::output_image_header
 
     wxDCFontChanger set_bigger_font(pdf_dc, pdf_dc.GetFont().Scaled(1.5));
     wxDCTextColorChanger set_white_text(pdf_dc, *wxWHITE);
+    // PDF !! This should not be necessary--see:
+    //   https://lists.nongnu.org/archive/html/lmi/2020-08/msg00003.html
+    wxDCTextBgModeChanger set_transparent_background(pdf_dc, 
wxPENSTYLE_TRANSPARENT);
 
     // Don't use html::text::from() here: instead, call
     // wxString::FromUTF8() directly, e.g., to preserve literal '&'.
---8<---8<---8<---8<---8<---8<---8<---8<---8<---8<---