[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [lmi] [lmi-commits] master f3ad703 3/3: Move an assignment to a memb
|
From: |
Greg Chicares |
|
Subject: |
Re: [lmi] [lmi-commits] master f3ad703 3/3: Move an assignment to a member initializer list |
|
Date: |
Sun, 7 Jun 2020 13:33:45 +0000 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 |
On 2020-06-07 10:06, Vadim Zeitlin wrote:
> On Sat, 6 Jun 2020 16:39:35 -0400 (EDT) Greg Chicares
> <gchicares@sbcglobal.net> wrote:
>
> GC> branch: master
> GC> commit f3ad703528daf7155e1c4069274a7557f5d56218
[...]
> GC> control_word(std::uint32_t w)
> GC> + :cw_ {ControlWordType::reserved_values |
> ControlWordType::settable & w}
> GC> {
> GC> - cw_ = ControlWordType::reserved_values |
> ControlWordType::settable & w;
> GC> }
>
> Out of curiosity, why did this need to be done?
I tried building with '-Weffc++', which flagged this,
and the fix seemed to be an obvious improvement.