lmi
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lmi] PATCH: disable -Wswitch-enum in boost_regex.hpp


From: Vadim Zeitlin
Subject: [lmi] PATCH: disable -Wswitch-enum in boost_regex.hpp
Date: Sun, 7 Jun 2020 13:28:43 +0200

 Hello,

 I'd like to enable -Wswitch-enum in CXXFLAGS used by configure, but
currently this fails because it's given for a switch inside
boost/regex/v4/regex_format.hpp. The official lmi makefiles don't suffer
from this problem because they use specific flags for compiling the object
files using Boost, but I think it would be better to just disable this
warning in the wrapper header for it instead, i.e.:

---------------------------------- >8 --------------------------------------
diff --git a/boost_regex.hpp b/boost_regex.hpp
index c67d0f195..fc1add1d7 100644
--- a/boost_regex.hpp
+++ b/boost_regex.hpp
@@ -39,6 +39,7 @@
 #       endif // 10 <= __GNUC__
 #   endif // 7 <= __GNUC__
 #   pragma GCC diagnostic ignored "-Wshadow"
+#   pragma GCC diagnostic ignored "-Wswitch-enum"
 #endif // defined __GNUC__
 #include <boost/regex.hpp>
 #if defined __clang__
---------------------------------- >8 --------------------------------------

(and possibly also remove one of -Wno-switch-enum occurrences in
workhorse.make, but I haven't tested this).

 Could you please change this or, perhaps, could I just commit this myself?
I'd like to do it before committing the changes to configure.ac adding more
warning options to it, so that it's closer to the official makefiles.

 Thanks in advance,
VZ

Attachment: pgpqKxHAOdqod.pgp
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]