Re: [lmi] Problems with the Cygwin tests

[Greg Chicares]

On 2019-05-10 00:12, Vadim Zeitlin wrote:
> On Thu, 9 May 2019 21:47:08 +0000 Greg Chicares <address@hidden> wrote:
> 
> GC> On 2019-05-08 18:11, Greg Chicares wrote:
> GC> > On 2019-05-07 15:05, Vadim Zeitlin wrote:
> GC> [...]
> GC> >> 5. The directory /opt/lmi/mingw/bin had to be added to the PATH for
> GC> >>    xsltproc.
> GC> > 
> GC> > Fixed.
> GC> 
> GC> Looking back over this flurry of recent changes, I wonder
> GC> why this one was necessary.
> 
>  Thanks for rechecking this, I actually wanted to do this myself, but
> forgot about it. After doing it now, it turns out that this is not the best
> way to solve the problem, we should add /opt/lmi/bin to the PATH instead.

I set out to make that change: bad patch below, just for giggles.

It started to feel wrong when I spent an inordinately large amount
of time drafting the commit message explaining why this revision
wouldn't be ideal anyway.

Then I noticed that I had spent an inordinately small amount of
time on correctness. You said "/opt/lmi/bin" above, but I already
had $srcdir defined in this script, so...

Anyway, this
| effort would be better spent on removing the libxslt dependency from
| lmi altogether
as the commit message notes, so I'm going to 'git reset --hard' and
get back to work now.

commit 8c95accb702ff1619e3146868a34d6c47dc5d624
Author: Gregory W. Chicares <address@hidden>
Date:   2019-05-10T12:08:32+00:00

    Improve a $PATH override
    
    An lmi-built msw-native 'xsltproc' depends on the libgcc DLL. If that
    program is invoked in $srcdir, there is no problem because that
    directory contains copies of compiler runtime files. However, to invoke
    it from a remote directory, that DLL must be found via $PATH. It is
    better to add $srcdir to $PATH than to specify the compiler's bin
    directory. See:
      https://lists.nongnu.org/archive/html/lmi/2019-05/msg00036.html
    Perhaps this test might fail if it's run with an explicit architecture
    other than the one that's been installed with 'make install', on a
    platform such as cygwin where an msw-native 'xsltproc' is used. That
    could be fixed by installing the appropriate cygwin package. However,
    effort would be better spent on removing the libxslt dependency from
    lmi altogether.

diff --git a/test_schemata.sh b/test_schemata.sh
index cf66cc10..681bdafd 100755
--- a/test_schemata.sh
+++ b/test_schemata.sh
@@ -44,8 +44,8 @@ cp --preserve "$srcdir"/sort_cell_subelements.xsl .
 
 echo "  Test cell-subelement sorting."
 
-PATH="/opt/lmi/mingw/bin:$PATH" xsltproc sort_cell_subelements.xsl sample.cns 
| tr --delete '\r' > sorted.cns
-PATH="/opt/lmi/mingw/bin:$PATH" xsltproc sort_cell_subelements.xsl sample.ill 
| tr --delete '\r' > sorted.ill
+PATH="$srcdir:$PATH" xsltproc sort_cell_subelements.xsl sample.cns | tr 
--delete '\r' > sorted.cns
+PATH="$srcdir:$PATH" xsltproc sort_cell_subelements.xsl sample.ill | tr 
--delete '\r' > sorted.ill
 diff --unified=0 sample.cns sorted.cns
 diff --unified=0 sample.ill sorted.ill