Re: [lmi] [PATCH] Install wxPdfDocument using Git

[Greg Chicares]

On 2018-08-27 19:51, Vadim Zeitlin wrote:
> 
>  I've created a PR replacing the existing install_wxpdfdoc.make, using wget
> to download the library snapshot from Github, with install_wxpdfdoc.sh
> which uses Git to get the sources directly. The new script is very similar
> to the existing install_wx.sh and, in fact, I wonder if we should reuse the
> common parts of the two scripts via some common install_functions.sh that
> could be sourced by both scripts. But for now I've kept things simple and
> didn't do it, please let me know if I should.

The simple way seems perfectly fine.

>  The changes themselves are at https://github.com/vadz/lmi/pull/91 and I've
> tested them by running the script with and without wxpdfdoc_commit_sha
> argument, it seems to work correctly. In particular, I could test my own
> proposed changes to configure.ac that were supposed to fix the problem with
> autoreconf and found that they broke the build instead, so they definitely
> shouldn't be applied (and I still have no idea why does that problem
> happen, unfortunately).

It was observed only on a corporate msw-10 machine. I can't retest
under that environment; Kim can, though not before Monday.