Re: [lmi] Switch to using C++11 uniform initialization in the ctor initializer lists?

[Vadim Zeitlin]

On Fri, 24 Aug 2018 00:04:05 +0000 Greg Chicares <address@hidden> wrote:

GC> On 2018-08-23 18:20, Vadim Zeitlin wrote:
GC> > On Thu, 23 Aug 2018 14:36:02 +0000 Greg Chicares <address@hidden> wrote:
GC> [...]
GC> > GC> - I'm working intensively on these files:
GC> > GC>     report_table*.?pp wx_table_generator.?pp
GC> > GC> and would prefer to modify those myself in order to avoid a merge.
GC> > 
GC> >  OK, I've left them out, but they both do contain member initializers 
using
GC> > parentheses.
GC> 
GC> I think the just-pushed commit b00dae44ea is what you had in mind
GC> for those files.

 Yes, thanks. Just in case you want to have a look at the rest of the
changes, I've updated the uniform-init branch on Github with all of them:

        https://github.com/vadz/lmi/compare/uniform-init?expand=1

 With these changes the code compiles and the unit tests pass. I've also
manually looked at all occurrences of vector-typed members followed by "{"
(actually " *{") in the code and confirmed that they were correct (i.e.
used either default or copy ctors) and that () were used for everything
else. But, again, I could have missed something, so I plan on redoing this
tomorrow -- unless you beat me to it. 

VZ