Re: [lmi] PATCH: simplify attachment page handling

[Vadim Zeitlin]

On Sun, 27 May 2018 12:03:02 +0000 Greg Chicares <address@hidden> wrote:

GC> On 2018-05-26 23:54, Greg Chicares wrote:
GC> >
GC> [ https://github.com/vadz/lmi/pull/84 ]
GC> > 
GC> > Cherry-picked and pushed.
GC> 
GC> Is there any reason not to apply the following?
GC> 
GC> 
---------8<--------8<--------8<--------8<--------8<--------8<--------8<-------
GC> diff --git a/ledger_pdf_generator_wx.cpp b/ledger_pdf_generator_wx.cpp
GC> index 48873e54..7d08aa06 100644
GC> --- a/ledger_pdf_generator_wx.cpp
GC> +++ b/ledger_pdf_generator_wx.cpp
GC> @@ -1523,9 +1523,6 @@ class ill_reg_numeric_summary_page : public 
standard_page
GC>  
GC>  class ill_reg_numeric_summary_attachment : public 
ill_reg_numeric_summary_page
GC>  {
GC> -  public:
GC> -    using ill_reg_numeric_summary_page::ill_reg_numeric_summary_page;
GC> -
GC>    private:
GC>      std::string get_page_number() const override
GC>      {
GC> 
--------->8-------->8-------->8-------->8-------->8-------->8-------->8-------

 No, there isn't any, it's either a leftover from an intermediate version
of the code or just an oversight, sorry about this.

 Please feel free to remove it if you'd like, otherwise I'll do it in
another patch later.

 Thanks for noticing this,
VZ