[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [lmi] PATCH: simplify attachment page handling
|
From: |
Greg Chicares |
|
Subject: |
Re: [lmi] PATCH: simplify attachment page handling |
|
Date: |
Sun, 27 May 2018 12:03:02 +0000 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 2018-05-26 23:54, Greg Chicares wrote:
>
[ https://github.com/vadz/lmi/pull/84 ]
>
> Cherry-picked and pushed.
Is there any reason not to apply the following?
---------8<--------8<--------8<--------8<--------8<--------8<--------8<-------
diff --git a/ledger_pdf_generator_wx.cpp b/ledger_pdf_generator_wx.cpp
index 48873e54..7d08aa06 100644
--- a/ledger_pdf_generator_wx.cpp
+++ b/ledger_pdf_generator_wx.cpp
@@ -1523,9 +1523,6 @@ class ill_reg_numeric_summary_page : public standard_page
class ill_reg_numeric_summary_attachment : public ill_reg_numeric_summary_page
{
- public:
- using ill_reg_numeric_summary_page::ill_reg_numeric_summary_page;
-
private:
std::string get_page_number() const override
{
--------->8-------->8-------->8-------->8-------->8-------->8-------->8-------