Re: [lmi] Removing empty messages from static_assert()

[Vadim Zeitlin]

On Fri, 9 Feb 2018 23:12:52 +0000 Greg Chicares <address@hidden> wrote:

GC> On 2018-02-09 22:17, Vadim Zeitlin wrote:
GC> > On Fri, 9 Feb 2018 21:04:09 +0000 Greg Chicares <address@hidden> wrote:
GC> > 
GC> > GC> On 2018-02-09 19:52, Greg Chicares wrote:
GC> > GC> > On 2018-02-09 16:36, Vadim Zeitlin wrote:
GC> > GC> > [...]
GC> > GC> >>  Would you mind if I submitted a trivial patch removing all of 
these ""
GC> > GC> >> from static_assert?
GC> > GC> 
GC> > GC> [...] I'll apply it when I see it.
GC> > 
GC> >  Thanks, here is the PR with the (as announced, trivial, changes):
GC> > 
GC> >   https://github.com/vadz/lmi/pull/66
GC> > 
GC> > I've only tested its compilation (with MinGW and MSVS 2017 too) because
GC> > it's really not supposed to have any run-time effects.
GC> 
GC> I did this, because it was so easy to do:
GC> 
GC> /opt/lmi/src/lmi[0]$for z in `grep --files-with-match static_assert *.?pp`; 
do <$z >../stash/$z sed -e '/static_assert/s/, "");/);/' ; done         

 Just for the record, I didn't do my changes like this, even if it was
tempting, but manually (well, ":git grep static-assert" and "s/, \?""//"
and then just Ctrl-N/"&" many times kind of manually, but still) to be sure
I didn't miss any corner cases.

GC> After updating your page here:
GC>   https://github.com/vadz/lmi/pulls

(updated now)

GC> 56 "Better fix for USE_SO_ATTRIBUTES=1 build", which I took a fresh
GC> look at the other day, just to see whether I could clear it easily.
GC> I can't.

 OK, it's not very important anyhow.

GC> BTW, I'll try no longer to CC you on mailing-list messages, but
GC> CC myself to increase the likelihood that I'll receive my own
GC> messages. I could re-add the CC to you, but that's probably just
GC> a nuisance.

 Not really a nuisance, but not really needed neither as I do receive all
the messages from the list just fine (touching wood).

 Thanks,
VZ