[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [lmi] Removing empty messages from static_assert()
From: |
Greg Chicares |
Subject: |
Re: [lmi] Removing empty messages from static_assert() |
Date: |
Fri, 9 Feb 2018 19:52:20 +0000 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 |
On 2018-02-09 16:36, Vadim Zeitlin wrote:
[...]
> Would you mind if I submitted a trivial patch removing all of these ""
> from static_assert?
Please go right ahead.
> The only problem is
> that such a patch would need to be applied relatively quickly, as it would
> touch a lot of files and so the risk of it getting out of date would be
> relatively high.
Now's a perfect time from my POV: I have no pending commits except
that 'const some_enum' signature you pointed out, but I don't want
to run my usual exhaustive series of tests just to push that, and
I'm confident I can recreate it after receiving your changes.
But, OTOH...
https://github.com/vadz/lmi/pulls
shows three new PRs: 63, 64, 65; should I tackle those first?
(If so, I'll get rid of 'const enum' at the same time, then push
everything and pass the baton to you.)
- [lmi] Removing empty messages from static_assert(), Vadim Zeitlin, 2018/02/09
- Re: [lmi] Removing empty messages from static_assert(),
Greg Chicares <=
- Re: [lmi] Removing empty messages from static_assert(), Greg Chicares, 2018/02/09
- Re: [lmi] Removing empty messages from static_assert(), Vadim Zeitlin, 2018/02/09
- Re: [lmi] Removing empty messages from static_assert(), Greg Chicares, 2018/02/09
- Re: [lmi] Removing empty messages from static_assert(), Vadim Zeitlin, 2018/02/10
- Re: [lmi] Removing empty messages from static_assert(), Greg Chicares, 2018/02/10
- Re: [lmi] Making repeated changes in Vim (was: Removing empty messages from static_assert()), Vadim Zeitlin, 2018/02/10