Re: [lmi] Enabling '-Wshadow' [Was: New clang errors fixes]

[Greg Chicares]

On 2017-09-27 23:48, Greg Chicares wrote:
[...]
> Another source of gcc '-Wshadow' warnings can be removed by updating
>   include/xmlwrapp/node.h, line 165 here:
>   https://github.com/vslavik/xmlwrapp/blob/master/include/xmlwrapp/node.h
> in this vein:
> 
> -      explicit text (const char *text) : t(text) {}
> +      explicit text (const char *arg) : t(arg) {}
> 
> using any name except 'text' for the argument.

That one's probably not controversial, but this one could be:

>   # XMLWRAPP !! '-Wno-deprecated-declarations' needed for auto_ptr
> wasn't auto_ptr already removed from xmlwrapp, so that I should
> just update to the latest version (hopefully after you consider
> the "text (const char *text) : t(text)" change above)?

because xmlwrapp might not want to throw away C++98 compatibility.
Therefore, I'll propose a patch for both.