Re: [lmi] PCH

[Vadim Zeitlin]

On Mon, 6 Jun 2016 20:37:59 +0000 Greg Chicares <address@hidden> wrote:

GC> On 2016-06-05 23:33, Greg Chicares wrote:
GC> > On 2016-06-05 22:23, Vadim Zeitlin wrote:
GC> >> On Sun, 5 Jun 2016 22:04:32 +0000 Greg Chicares <address@hidden> wrote:
GC> >> 
GC> >> GC> (1) #include LMI_PCH_HEADER
GC> >> GC> 
GC> >> GC> What macro definition makes that work with gcc?
GC> >> 
GC> >>  Nothing really special, i.e. here is what I have in Makefile.am:
GC> >> 
GC> >>  AM_CXXFLAGS = -DLMI_PCH_HEADER="<pchfile.hpp>"
GC> >> 
GC> >> and, for the GUI code:
GC> >> 
GC> >>  libskeleton_la_CXXFLAGS = ... -DLMI_PCH_HEADER="<pchfile_wx.hpp>"
GC> > 
GC> > I'll change the '.cpp' files,
GC> 
GC> Pushed.

 Thanks again for doing this, this is enough to resolve almost all
differences between my branch sources and master all while still using the
precompiled headers in the MSVC build. I just had to adjust a couple of
files to include pchfile_wx.hpp instead of pchfile.hpp, please see
https://github.com/vadz/lmi/pull/42 

 I had a small problem with just one file, main_common.cpp, which is also
part of libskeleton, and so would normally need to include pchfile_wx.hpp,
but this didn't seem to be appropriate to do for this file as it's also
used as part of other targets (e.g. product_files) which don't have
anything to do with wxWidgets. After hesitating for some time, I just moved
this file from libskeleton project to liblmi one and removed it from the
other targets (such as product_files) and everything builds perfectly for
me. I wonder if this shouldn't be also done in objects.make, this file just
doesn't seem to belong to libskeleton, unless I'm missing something.

GC> I wonder about one thing: the original 'pchfile.hpp' included
GC> 'wx/wxprec.h', and it's still mentioned here:
GC>   https://wiki.wxwidgets.org/Precompiled_Headers
GC> but not here:
GC>   https://github.com/vadz/lmi/blob/tt/pchfile_wx.hpp
GC> Perhaps you've tailored that list of files to lmi's needs.

 Yes, it was Vaclav and not me and I'm not honestly sure if it's still
correct, but some tests were done back in 2010 (?) to find the best set of
headers specifically for lmi build.

GC> > but leave 'Makefile.am' to you.
GC> 
GC> I didn't touch that.

 Can I just commit my changes to this one now?

 Thanks,
VZ