Re: [lmi] shadowing warnings

[Greg Chicares]

On 2016-06-05 17:48, Vadim Zeitlin wrote:
[...zillions of '-Wshadow' warnings...]
>  It turns out that this was, luckily, just a bug which was fixed in the
> later version, see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=57709, and

Thanks for letting me know. The number of warnings was surprising.

> after also testing with g++ 5.3, I can also confirm that -Wshadow works
> with just the PR 40 with it too, so it's only 4.9 that requires more
> changes. IMHO it doesn't make sense to do a lot of these ugly changes just
> for 4.9 and, if you're interested in enabling -Wshadow at all, it would be
> better to wait until we update to g++5 or 6 and return to this then.
> 
>  Please let me know if you disagree, otherwise I'll just keep PR 40 open
> but mark it as "postponed".

Agreed.