Re: [lmi] [PATCH] Don't compile getopt.cpp twice as part getopt_test

[Greg Chicares]

On 01/26/2015 01:36 PM, Vadim Zeitlin wrote:
[...]
> getopt.o just appears twice in the list of the dependencies of
> getopt_test.exe, but this doesn't result in it being actually linked twice,
> and has nothing to do with --allow-multiple-definition option which is not
> used when linking this test.

Thanks for the quick update. I doubted whether '--allow-multiple-definition'
was used here, and was about to look into that; now I won't.

> I still think the patch should be applied as there is no need to list this
> file twice.

Agreed. It's a defect that it appears twice (even if it causes no observable
problem at present). Other $(common_test_objects) components do not: for
example, 'fenv_lmi_test$(EXEEXT)' does not list 'fenv_lmi.o' as an explicit
dependency; and 'alert_test$(EXEEXT)' is similar.

Committed 20150127T0019Z, revision 6105.