Re: [lmi] [PATCH] Don't compile getopt.cpp twice as part getopt_test

[Vadim Zeitlin]

On Mon, 26 Jan 2015 14:30:54 +0100 I wrote:

Me>  While testing linking of the tests under Linux using automake, I found a
Me> problem with one of them: getopt_test includes, IMO mistakenly, getopt.cpp
Me> twice: first explicitly as one of the dependencies and second as part of
Me> $(common_test_objects). This went unnoticed when using the official build
Me> system under MSW as it uses --allow-multiple-definition linker option

 Sorry, once again I've realized I had written something wrong immediately
after (but not before <sigh>) sending this email. The above explanation is
wrong, it doesn't result in any problems with the official build system
because getopt.o just appears twice in the list of the dependencies of
getopt_test.exe, but this doesn't result in it being actually linked twice,
and has nothing to do with --allow-multiple-definition option which is not
used when linking this test.

 But while the explanation was wrong, everything else remains correct, i.e.
I still think the patch should be applied as there is no need to list this
file twice.

 Sorry for the confusion,
VZ