lmi
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [lmi] switch census view to use wxDataViewCtrl


From: Greg Chicares
Subject: Re: [lmi] switch census view to use wxDataViewCtrl
Date: Tue, 02 Aug 2011 15:21:47 +0000
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.17) Gecko/20110414 Thunderbird/3.1.10

On 2011-02-26 19:55Z, Václav Slavík wrote:
> 
>> below is the patch that does first step of enabling in-place editing: it
>> changes CensusView to use wxDataViewCtrl instead of wxListCtrl. Note
>> that it's just the first step, it changes the implementation without
>> changing the UI too much visibly.
> 
> An updated version of the patch is below;

Committed (with immaterial modifications) 20110802T1517Z.

> this one disables actions only
> doable on one item (edit cell, run, ...) in case of multiple selection.

Thanks, that's certainly an improvement.

A desirable (IMO) feature of the old wxListCtrl was that at least one row
was always "selected". I write "selected" in quotes because
  File | New | Census
  Census | Edit cell
would edit the first (and only) cell, even though no cell in the listview
had any highlight (in msw, neither the dotted-line outline, nor the reverse-
color highlight). Now, in HEAD, the dotted-line outline is present, but not
the reverse-color highlight, and "Census | Edit cell" is disabled. Can you
show me how to patch HEAD to select the first cell whenever no cell would
otherwise be selected?

This behavior matters in two cases: when a census has first been loaded, or
when a succesful deletion ("Census | Delete cell(s)") has been performed.

A curious side-effect in HEAD at the moment is that after
  File | New | Census
there seems to be no way to edit the (one and only) cell solely by using
the keyboard. (That won't matter if the first cell is always selected).
Wait--I take that back: I can select it with PgUp or PgDn. But the reason I
mentioned it is that, by pressing random keys, I stumbled upon a really
peculiar behavior--close all child windows and do this (same thing twice):
  File | New | Census
  File | New | Census
then press Tab repeatedly--the dotted-line outline moves back and forth
between the two dataview controls. I'm guessing that's not intended.

Introducing a new topic: after
  Census | Add cell
it would probably be better to select the newly-added cell (even though
the old listview-based implementation didn't do that). Can you show me how
to do that please?



reply via email to

[Prev in Thread] Current Thread [Next in Thread]